fix(cron): remove output dirs for completed one-shot jobs

[LeonSGP43]

What does this PR do?

Cleans up cron output directories when a completed one-shot job is auto-removed by the repeat-limit path, so stale output folders do not accumulate after the job record is deleted.

Related Issue

Fixes #22065

Type of Change

• 🐛 Bug fix (non-breaking change that fixes an issue)

Changes Made

• Added output-directory cleanup to the repeat-limit deletion path in cron/jobs.py
• Added a regression test in tests/cron/test_jobs.py

How to Test

1. Run uv run --frozen pytest -q -o addopts='' tests/cron/test_jobs.py -k 'repeat_limit_removes_job or repeat_limit_removes_output_dir'
2. Run uv run --frozen ruff check cron/jobs.py tests/cron/test_jobs.py
3. Confirm both commands pass

Checklist

Code

• I've read the Contributing Guide
• My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
• I searched for existing PRs to make sure this isn't a duplicate
• My PR contains only changes related to this fix/feature (no unrelated commits)
• I've run pytest tests/ -q and all tests pass
• I've added tests for my changes (required for bug fixes, strongly encouraged for features)
• I've tested on my platform: macOS 15.x

Documentation & Housekeeping

• I've updated relevant documentation (README, docs/, docstrings) — or N/A
• I've updated cli-config.yaml.example if I added/changed config keys — or N/A
• I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
• I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
• I've updated tool descriptions/schemas if I changed tool behavior — or N/A

Screenshots / Logs

• uv run --frozen pytest -q -o addopts='' tests/cron/test_jobs.py -k 'repeat_limit_removes_job or repeat_limit_removes_output_dir' -> 2 passed

[alt-glitch]

Duplicate of #22066 — same fix adding output-dir cleanup in mark_job_run() repeat-limit path. Both fix #22065.

[teknium1]

Thanks for identifying the orphaned-output path. The premise remains valid on current main: cron/jobs.py:1426-1430 removes an exhausted job without cleanup, while save_job_output() creates its directory at cron/jobs.py:1914-1919.

Problems

• The direct OUTPUT_DIR / job_id path bypasses _job_output_dir() (cron/jobs.py:255-268). Current remove_job() resolves the safe path before persisting deletion (cron/jobs.py:1363-1370); this branch needs the same fail-closed ordering.
• Current main has two additional exhausted-one-shot deletion paths: claim_dispatch() (cron/jobs.py:1501-1506) and _get_due_jobs_locked() (cron/jobs.py:1818-1830). They need equivalent cleanup for the bug class to be covered.

Suggested changes

• Resolve _job_output_dir(job["id"]) before removal/save, then clean it after persistence in all three paths.
• Add seeded-output tests for repeat-limit, dispatch-limit, and stale-due removal.

Automated hermes-sweeper review.

[teknium1]

Please use _job_output_dir(job["id"]) and resolve it before jobs.pop() / save_jobs(), as remove_job() now does. Directly composing OUTPUT_DIR / job_id bypasses the current legacy-ID path-escape guard in cron/jobs.py:255-268.