Skip to content

fix(cli): preserve Ctrl-J newline on macOS - #23448

Closed
ForgedFinancial wants to merge 1 commit into
NousResearch:mainfrom
ForgedFinancial:fix/macos-ctrl-j-newline-2026-05-10
Closed

fix(cli): preserve Ctrl-J newline on macOS#23448
ForgedFinancial wants to merge 1 commit into
NousResearch:mainfrom
ForgedFinancial:fix/macos-ctrl-j-newline-2026-05-10

Conversation

@ForgedFinancial

Copy link
Copy Markdown

Summary

  • preserve c-j/Ctrl-J as a multiline newline shortcut on macOS instead of binding it to submit
  • keep bare local Linux c-j submit fallback unchanged
  • update CLI help text and focused tests

Verification

  • python -m pytest -q -n 0 tests/cli/test_ctrl_enter_newline.py tests/cli/test_cli_init.py::TestPromptToolkitTerminalCompatibility::test_lf_enter_binds_to_submit_handler_posix

@alt-glitch alt-glitch added type/bug Something isn't working comp/cli CLI entry point, hermes_cli/, setup wizard P2 Medium — degraded but workaround exists labels May 10, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Related to / competes with #22911 (same fix: preserve c-j for newline on macOS). Also competes with #22495 (Ctrl+Enter newline over SSH/WSL). These should be coordinated to avoid conflicts.

@ForgedFinancial

Copy link
Copy Markdown
Author

MacBook verification refresh: the same Ctrl+J macOS newline fix was re-applied and tested on current Danny MacBook Hermes source. Evidence: local main 948084734 contains the patch; refreshed remote safety branch ForgedFinancial:fix/macos-ctrl-j-newline-durable-2026-05-12 points to 948084734; focused tests passed: 11 passed in tests/cli/test_ctrl_enter_newline.py plus test_cli_init LF submit compatibility; macOS _preserve_ctrl_enter_newline assertion passed; canonical bootstrap now enforces HERMES_CTRL_J_NEWLINE_CHECK=PASS in ForgedFinancial/canonical-workspace#35. Merge attempt from ForgedFinancial failed due upstream permission: MergePullRequest not permitted, so PR remains open/mergeable for maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants