fix(cli): wire sessions and indicator slash commands - #23289
Closed
LeonSGP43 wants to merge 1 commit into
Closed
Conversation
Collaborator
This was referenced May 11, 2026
12 tasks
This was referenced May 15, 2026
Contributor
|
Closing — this was solved on main via #25986 (commit d6c488f, May 14), salvaged from @explainanalyze's #25231. The classic CLI now wires Five PRs all converged on this gap (per the cluster comment on #25231): #21680, #22962, #23289, #24412, #25231. Thanks @LeonSGP43 — your fix was correct on its own, the merged version just shipped first. Tracking issues #21677 and #22951 are being closed in parallel. |
This was referenced May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Wire two already-registered slash commands into the classic CLI command dispatcher so they no longer silently do nothing outside TUI mode.
Related Issue
Fixes #22960
Type of Change
Changes Made
/sessionsdispatch in/Users/leongong/Desktop/LeonProjects/worktrees/hermes-agent/hermes-22960-cli-sessions-indicator/cli.pyto reuse_show_recent_sessions(reason="resume")/indicatorhandling in classic CLI mode, including normalized status display and config writes todisplay.tui_status_indicator/Users/leongong/Desktop/LeonProjects/worktrees/hermes-agent/hermes-22960-cli-sessions-indicator/tests/cli/test_sessions_indicator_commands.pyHow to Test
uv run --frozen pytest -q -o addopts='' tests/cli/test_sessions_indicator_commands.py/sessionsto confirm recent sessions render or show the empty-state message/indicator statusand/indicator emojito confirm status normalization and config persistence both work in CLI modeChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
uv run --frozen pytest -q -o addopts='' tests/cli/test_sessions_indicator_commands.py→7 passeduv run --frozen ruff check cli.py tests/cli/test_sessions_indicator_commands.py→ passed