Skip to content

fix(cli): wire sessions and indicator slash commands - #23289

Closed
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:codex/22960-cli-sessions-indicator
Closed

fix(cli): wire sessions and indicator slash commands#23289
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:codex/22960-cli-sessions-indicator

Conversation

@LeonSGP43

Copy link
Copy Markdown
Contributor

What does this PR do?

Wire two already-registered slash commands into the classic CLI command dispatcher so they no longer silently do nothing outside TUI mode.

Related Issue

Fixes #22960

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

  • add /sessions dispatch in /Users/leongong/Desktop/LeonProjects/worktrees/hermes-agent/hermes-22960-cli-sessions-indicator/cli.py to reuse _show_recent_sessions(reason="resume")
  • add a small empty-state message when no resumable CLI sessions exist
  • add /indicator handling in classic CLI mode, including normalized status display and config writes to display.tui_status_indicator
  • add focused regression coverage in /Users/leongong/Desktop/LeonProjects/worktrees/hermes-agent/hermes-22960-cli-sessions-indicator/tests/cli/test_sessions_indicator_commands.py

How to Test

  1. Run uv run --frozen pytest -q -o addopts='' tests/cli/test_sessions_indicator_commands.py
  2. Start classic CLI mode (no TUI) and run /sessions to confirm recent sessions render or show the empty-state message
  3. Run /indicator status and /indicator emoji to confirm status normalization and config persistence both work in CLI mode

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform: macOS 15.x

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

Screenshots / Logs

  • uv run --frozen pytest -q -o addopts='' tests/cli/test_sessions_indicator_commands.py7 passed
  • uv run --frozen ruff check cli.py tests/cli/test_sessions_indicator_commands.py → passed

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/cli CLI entry point, hermes_cli/, setup wizard labels May 10, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Duplicate of #22962 — same fix wiring /sessions and /indicator dispatch branches in process_command(). Both fix #22960.

@teknium1

Copy link
Copy Markdown
Contributor

Closing — this was solved on main via #25986 (commit d6c488f, May 14), salvaged from @explainanalyze's #25231. The classic CLI now wires /sessions through process_command and /sessions [id_or_title] delegates to _handle_resume_command.

Five PRs all converged on this gap (per the cluster comment on #25231): #21680, #22962, #23289, #24412, #25231. Thanks @LeonSGP43 — your fix was correct on its own, the merged version just shipped first.

Tracking issues #21677 and #22951 are being closed in parallel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/sessions and /indicator slash commands silently fail in CLI mode

3 participants