Conversation
Contributor
Collaborator
|
Automated hermes-sweeper review: the #21735 crash path this duplicate PR targets is already fixed on current Evidence:
Note: current main resolves this conservatively by blocking symlinked skill install destinations rather than unlinking/replacing them. That still satisfies #21735's expected behavior, which allowed either a successful install or a clear non-traceback error. |
This was referenced Jul 30, 2026
Bug: skill install crashes with ValueError when SKILLS_DIR or install path contains a symlink
#53403
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes #21735 with a narrow bugfix that keeps the affected path aligned with the current Hermes behavior without widening the change surface.
Related Issue
Fixes #21735
Type of Change
Changes Made
install_from_quarantine()to replace an existing symlink destination without deleting the real target behind it--forceinstalls that land on a symlinked skill pathHow to Test
uv run --frozen pytest -q -o addopts='' tests/tools/test_skills_hub.py -k force_install_replaces_symlink_destinationuv run --frozen ruff check tools/skills_hub.py tests/tools/test_skills_hub.pyhermes skills installcrashes with OSError when install destination is a symlink #21735 now follows the expected behavior.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
Screenshots / Logs
Targeted skill-install regression test and Ruff checks passed locally on macOS.