Skip to content

fix(kanban): skip invalid task skills and add recovery commands #23154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
qWaitCrypto wants to merge 7 commits into from
Closed

fix(kanban): skip invalid task skills and add recovery commands #23154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7b635aa
fix(kanban): validate task skills and surface stuck task diagnostics
qWaitCrypto May 10, 2026
22c6fed
fix(kanban): tighten edit recovery semantics
qWaitCrypto May 10, 2026
a8104b4
test(kanban): isolate dashboard diagnostics profile checks
qWaitCrypto May 10, 2026
a215786
fix(kanban): skip bad task skills and add recovery commands
qWaitCrypto May 10, 2026
fd03875
fix(kanban): tighten dispatch recovery invariants
qWaitCrypto May 10, 2026
c3e621b
Merge remote-tracking branch 'upstream/main' into fix/kanban-diagnost…
qWaitCrypto May 10, 2026
00ab664
Merge branch 'fix/kanban-diagnostics-preflight-22921' into fix/kanban…
qWaitCrypto May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
164 changes: 142 additions & 22 deletions hermes_cli/kanban.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,12 +406,12 @@ def build_parser(parent_subparsers: argparse._SubParsersAction) -> argparse.Argu

p_edit = sub.add_parser(
"edit",
help="Edit recovery fields on an already-completed task",
help="Edit recovery fields on a task",
)
p_edit.add_argument("task_id")
p_edit.add_argument(
"--result",
required=True,
default=None,
help="Backfilled task result text for a done task",
)
p_edit.add_argument(
Expand All @@ -424,6 +424,21 @@ def build_parser(parent_subparsers: argparse._SubParsersAction) -> argparse.Argu
default=None,
help="JSON dict of structured facts to store on the latest completed run.",
)
p_edit.add_argument(
"--clear-skills",
action="store_true",
help="Clear persisted task skills on a non-running task.",
)
p_edit.add_argument(
"--reset-failures",
action="store_true",
help="Reset consecutive failure counter and last failure error.",
)
p_edit.add_argument(
"--clear-claim",
action="store_true",
help="Clear persisted claim fields on a non-running task.",
)

p_block = sub.add_parser("block", help="Mark one or more tasks blocked")
p_block.add_argument("task_id")
Expand Down Expand Up @@ -1037,25 +1052,29 @@ def _cmd_create(args: argparse.Namespace) -> int:
file=sys.stderr,
)
return 2
with kb.connect() as conn:
task_id = kb.create_task(
conn,
title=args.title,
body=args.body,
assignee=args.assignee,
created_by=args.created_by or _profile_author(),
workspace_kind=ws_kind,
workspace_path=ws_path,
tenant=args.tenant,
priority=args.priority,
parents=tuple(args.parent or ()),
triage=bool(getattr(args, "triage", False)),
idempotency_key=getattr(args, "idempotency_key", None),
max_runtime_seconds=max_runtime,
skills=getattr(args, "skills", None) or None,
max_retries=max_retries,
)
task = kb.get_task(conn, task_id)
try:
with kb.connect() as conn:
task_id = kb.create_task(
conn,
title=args.title,
body=args.body,
assignee=args.assignee,
created_by=args.created_by or _profile_author(),
workspace_kind=ws_kind,
workspace_path=ws_path,
tenant=args.tenant,
priority=args.priority,
parents=tuple(args.parent or ()),
triage=bool(getattr(args, "triage", False)),
idempotency_key=getattr(args, "idempotency_key", None),
max_runtime_seconds=max_runtime,
skills=getattr(args, "skills", None) or None,
max_retries=max_retries,
)
task = kb.get_task(conn, task_id)
except ValueError as exc:
print(f"kanban: create: {exc}", file=sys.stderr)
return 2
if getattr(args, "json", False):
print(json.dumps(_task_to_dict(task), indent=2, ensure_ascii=False))
else:
Expand Down Expand Up @@ -1555,6 +1574,85 @@ def _cmd_complete(args: argparse.Namespace) -> int:


def _cmd_edit(args: argparse.Namespace) -> int:
recovery_flags = sum(bool(x) for x in [
getattr(args, "clear_skills", False),
getattr(args, "reset_failures", False),
getattr(args, "clear_claim", False),
])
if recovery_flags > 1:
print(
"kanban: edit accepts at most one recovery action flag "
"(--clear-skills, --reset-failures, or --clear-claim)",
file=sys.stderr,
)
return 2
if getattr(args, "clear_skills", False) and any([
args.result is not None,
getattr(args, "summary", None) is not None,
getattr(args, "metadata", None) is not None,
]):
print(
"kanban: edit --clear-skills cannot be combined with "
"--result/--summary/--metadata",
file=sys.stderr,
)
return 2
if getattr(args, "reset_failures", False) and any([
args.result is not None,
getattr(args, "summary", None) is not None,
getattr(args, "metadata", None) is not None,
]):
print(
"kanban: edit --reset-failures cannot be combined with "
"--result/--summary/--metadata",
file=sys.stderr,
)
return 2
if getattr(args, "clear_claim", False) and any([
args.result is not None,
getattr(args, "summary", None) is not None,
getattr(args, "metadata", None) is not None,
]):
print(
"kanban: edit --clear-claim cannot be combined with "
"--result/--summary/--metadata",
file=sys.stderr,
)
return 2
if (
not getattr(args, "clear_skills", False)
and not getattr(args, "reset_failures", False)
and not getattr(args, "clear_claim", False)
and args.result is None
):
print(
"kanban: edit requires --result unless a recovery flag is used",
file=sys.stderr,
)
return 2
if getattr(args, "reset_failures", False):
with kb.connect() as conn:
if not kb.reset_task_failures(conn, args.task_id):
print(f"cannot edit {args.task_id} (unknown id)", file=sys.stderr)
return 1
print(f"Edited {args.task_id}")
return 0
if getattr(args, "clear_claim", False):
with kb.connect() as conn:
ok = kb.edit_task_recovery_fields(
conn,
args.task_id,
clear_claim=True,
)
if not ok:
print(
f"cannot clear claim on {args.task_id} "
f"(unknown id or task is running)",
file=sys.stderr,
)
return 1
print(f"Edited {args.task_id}")
return 0
raw_meta = getattr(args, "metadata", None)
metadata = None
if raw_meta:
Expand All @@ -1566,13 +1664,29 @@ def _cmd_edit(args: argparse.Namespace) -> int:
print(f"kanban: --metadata: {exc}", file=sys.stderr)
return 2
with kb.connect() as conn:
if not kb.edit_completed_task_result(
if not kb.edit_task_recovery_fields(
conn,
args.task_id,
result=args.result,
summary=getattr(args, "summary", None),
metadata=metadata,
clear_skills=bool(getattr(args, "clear_skills", False)),
clear_claim=bool(getattr(args, "clear_claim", False)),
):
if getattr(args, "clear_skills", False):
print(
f"cannot clear skills on {args.task_id} "
f"(unknown id or task is running)",
file=sys.stderr,
)
return 1
if getattr(args, "clear_claim", False):
print(
f"cannot clear claim on {args.task_id} "
f"(unknown id or task is running)",
file=sys.stderr,
)
return 1
print(
f"cannot edit {args.task_id} (unknown id or task is not done)",
file=sys.stderr,
Expand Down Expand Up @@ -1675,6 +1789,7 @@ def _cmd_dispatch(args: argparse.Namespace) -> int:
],
"skipped_unassigned": res.skipped_unassigned,
"skipped_nonspawnable": res.skipped_nonspawnable,
"skipped_invalid_skills": res.skipped_invalid_skills,
}, indent=2))
return 0
print(f"Reclaimed: {res.reclaimed}")
Expand All @@ -1699,6 +1814,11 @@ def _cmd_dispatch(args: argparse.Namespace) -> int:
f"Skipped (non-spawnable assignee — terminal lane, OK): "
f"{', '.join(res.skipped_nonspawnable)}"
)
if res.skipped_invalid_skills:
print(
f"Skipped (invalid task skills): "
f"{', '.join(res.skipped_invalid_skills)}"
)
return 0


Expand Down
Loading
Loading