Conversation
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skip_soulparameter frombuild_context_files_prompt().SOUL.mdloading exclusively inload_soul_md()as the identity layer.Why
skip_soulwas added when SOUL.md moved from the project context block to the primary identity slot in #1922. The main prompt assembly now hasload_soul_identityfor the real cron use case from #17509, so the helper-level fallback path preserves old mixed context behavior and makes the prompt order harder to understand.How to test
.venv/bin/python -m pytest -o addopts='' tests/agent/test_prompt_builder.py::TestBuildContextFilesPrompt tests/run_agent/test_run_agent.py::TestBuildSystemPrompt tests/cron/test_cron_workdir.py::TestRunJobTerminalCwd -q.venv/bin/python - <<'PY' ... PYsmoke test coveringload_soul_md()plusbuild_context_files_prompt()git diff --checkPlatforms tested
.venvRelated
Cross-platform impact
This is prompt assembly cleanup only. It removes duplicate SOUL.md loading from the context helper and does not add platform-specific behavior.