fix(banner): invalidate cached update check when local HEAD changes - #22979
Open
airly7429-dev wants to merge 1 commit into
Open
fix(banner): invalidate cached update check when local HEAD changes#22979airly7429-dev wants to merge 1 commit into
airly7429-dev wants to merge 1 commit into
Conversation
Collaborator
Contributor
|
Thanks for isolating the stale-HEAD cache case. The underlying issue is still present on current main: Problems
Suggested changes
Automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes stale banner update-check results when the local
HEADchanges.Previously, cached update-check state could survive across local branch/commit
changes, which made the banner show outdated information. This change invalidates
the cache when the local
HEADno longer matches the cached revision and addstest coverage for that behavior.
Changes
HEADchangeTesting
python -m pytest tests/hermes_cli/test_banner.py -qNotes
This PR only changes banner/update-check behavior and does not change webhook or
gateway runtime behavior.
What does this PR do?
Related Issue
Fixes #
Type of Change
Changes Made
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
hermes --toolsets skills -q "Use the X skill to do Y"Screenshots / Logs