Conversation
Collaborator
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR covers the remaining Skills Hub SSRF fetch paths that are not addressed in #10029's current scope.
#10029hardens the well-known and Skills.sh fetch paths, but the same SSRF surface is still reachable through:UrlSource._fetch_text()— directhermes skills install https://.../SKILL.mdClawHubSource._fetch_text()— ClawHub version metadatarawUrl/downloadUrl/urlfile fetchesThis PR keeps scope narrow and applies the same SSRF protection model to those remaining text-fetch paths.
Why this matters
Without this change, a malicious or compromised Skills Hub source can still trigger outbound requests to private/internal targets through paths not covered by #10029.
Examples:
hermes skills install http://127.0.0.1:<port>/x/SKILL.mdrawUrl: http://169.254.169.254/...Changes made
tools/skills_hub.pyWellKnownSkillSource._parse_index()WellKnownSkillSource._fetch_text()UrlSource._fetch_text()ClawHubSource._fetch_text()UrlSourceUrlSourcerawUrltargets in ClawHub fallback metadata fetchesScope
This PR does not introduce a new security model. It keeps the scope narrow and only extends the existing Skills Hub SSRF hardening to the remaining uncovered text-fetch surfaces.
Tests
Both pass locally.
Related