fix: run computer use post-setup when enabling tool

[sgtworkman]

Summary

• Make the hermes tools enable flow notice pending no-key provider post-setup hooks.
• Add a cheap completion predicate for cua_driver, including HERMES_CUA_DRIVER_CMD override support.
• Add regression coverage for Computer Use when cua-driver is missing, installed, or custom-command configured.

Test Plan

• scripts/run_tests.sh tests/hermes_cli/test_tools_config.py tests/hermes_cli/test_tools_disable_enable.py tests/hermes_cli/test_image_gen_picker.py -q
• git diff --check
• Added-lines static scan for obvious secrets/dangerous patterns

Notes

• Fork default branch sgtworkman/main was fast-forwarded to origin/main and verified at 0 0 divergence before pushing this PR branch.

[sgtworkman]

Validation update

Rebased this PR branch onto current origin/main and force-pushed with lease.

Local validation:

• scripts/run_tests.sh tests/hermes_cli/test_tools_config.py tests/hermes_cli/test_tools_disable_enable.py tests/hermes_cli/test_image_gen_picker.py -q — 98 passed
• git diff --check — clean
• Added-lines static scan for obvious secrets/dangerous patterns — clean

CI status: GitHub Actions are currently action_required for this fork PR, so no checks have executed yet. Maintainer approval is needed before Actions can run.

Head: f8ef1e0ca86ddd4530d16626c8087a4f6c24e44c

[sgtworkman]

Validation update

Addressed an independent review finding before marking this ready:

• Kept the Computer Use setup gate for no-key providers so hermes tools prompts/runs cua-driver post-setup when the driver is missing.
• Made cua_driver post-setup honor HERMES_CUA_DRIVER_CMD consistently for:
  • installed-state detection
  • --version probing
  • post-install verification
• Added regressions for:
  • missing driver still requiring configuration
  • installed default driver skipping setup
  • custom driver command satisfying setup
  • blank custom command falling back to cua-driver
  • post-setup version probing the custom command
  • a default cua-driver not satisfying a missing custom override

Local validation:

scripts/run_tests.sh tests/hermes_cli/test_tools_config.py -v

Result: 72 passed.

Static added-line security scan: 0 findings.
Independent diff review after the parity fix: passed, no blocking security or logic issues.

CI note: GitHub Actions for this fork PR are currently action_required/maintainer-gated, so no remote check logs have run yet.

[sgtworkman]

Validation refresh

Rebased this PR onto the latest origin/main after upstream advanced, then reran local validation.

Head: 860e91fbc
Base observed locally: origin/main at 08ec60277
Branch divergence after rebase: 0 behind / 1 ahead vs origin/main.

Local validation:

scripts/run_tests.sh tests/hermes_cli/test_tools_config.py -v

Result: 72 passed.

Review status:

• Static added-line security scan: 0 findings.
• Independent diff review found one HERMES_CUA_DRIVER_CMD parity issue; fixed before push.
• Independent follow-up review after the parity fix: passed, no blocking security or logic issues.

CI note: GitHub Actions for this fork PR are still maintainer-gated / action_required, so remote checks have not actually run yet.

[sgtworkman]

Validation refresh

Rebased onto latest origin/main after upstream advanced and force-pushed with lease.

Head: 02e21ffc3
Branch divergence vs origin/main: 0 behind / 1 ahead.

Local validation:

scripts/run_tests.sh tests/hermes_cli/test_tools_config.py tests/cron/test_cron_no_agent.py tests/cron/test_cron_script.py -q

Result for shared validation slice: 125 passed.

This PR-specific test file remains covered by that run: tests/hermes_cli/test_tools_config.py.

[sgtworkman]

Local integration validation

Validated the current open PR stack locally while GitHub Actions remain maintainer-gated for fork PRs.

Temporary stack from fresh origin/main (44cdf555a) merged these PR heads cleanly, with no conflicts:

• fix: run computer use post-setup when enabling tool #22776 — fix/computer-use-tools-installs-cua-driver
• fix: honor active repo and dashboard chat theme #22650 — fix/dashboard-chat-theme-update-check
• fix: validate cron no-agent update invariants #21031 — fix/cron-no-agent-validation

Combined targeted validation:

scripts/run_tests.sh \
  tests/hermes_cli/test_tools_config.py \
  tests/hermes_cli/test_update_check.py \
  tests/hermes_cli/test_web_server.py \
  tests/cron/test_cron_no_agent.py \
  tests/cron/test_cron_script.py -q

Result: 280 passed in 3.04s.

Dashboard build also passed:

cd web && npm run build

Result: passed; only the existing Vite chunk-size warning was emitted.

The temp worktree was removed after validation. No production/deploy action was performed.

[teknium1]

Salvaged via PR #30316 (commit caf0f30 on main). Your commit was cherry-picked onto current main with your authorship preserved. Closes the silent-no-op bug where enabling Computer Use via hermes tools didn't trigger the cua-driver install hook. Thanks!