fix(gateway): use portable ps scan for gateway PIDs - #22698
Closed
iuyua9 wants to merge 1 commit into
Closed
Conversation
Contributor
|
Closing in favor of #22860 (salvage of #22693 by @wesleysimplicio). #22693 addresses a more severe failure mode — slim Docker images that ship without procps at all (no ps binary), which is the dominant production deployment surface. Your /proc-less macOS BSD ps flag matrix targets a different failure mode (#10684) which is complementary and can layer on top in a follow-up — your ps aux matrix would replace the still-broken ps -A eww fallback that #22693 keeps in its no-/proc branch. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
ps ewwflags when scanning gateway processes on non-Windows systemsps auxdirectly on macOS, where the BSDpsoutput shape is stable for this scanps -A ww -o pid=,command=on other POSIX systems and fall back tops auxwhen that output is emptyWhy:
find_gateway_pids()backshermes gateway statusand update/restart flowsTests:
python3 -m pytest tests/hermes_cli/test_gateway.py -qgit diff --checkRelated:
ps -A ewwscan.