fix(metadata): update hy3-preview context length to 262144 - #22270
Closed
alblez wants to merge 1 commit into
Closed
Conversation
OpenRouter's live API now reports hy3-preview with context_length=262144 (up from the original 256000). Update both the static fallback table in DEFAULT_CONTEXT_LENGTHS and the corresponding test assertion. The test was failing because get_model_context_length() hits the OpenRouter metadata cache (step 6 in resolution order) which returns 262144, taking priority over the stale hardcoded 256000 in step 8.
alt-glitch
added
type/test
Contributor
|
Automated hermes-sweeper review: this fix is already present on current main. Evidence:
Thanks for catching the stale metadata; main now has the fix. |
teknium1
added
the
sweeper:implemented-on-main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the failing test
TestTencentTokenhubContextLength::test_hy3_preview_context_lengthby updating the stale context length value forhy3-preview.Fixes #22268
Changes
agent/model_metadata.pyDEFAULT_CONTEXT_LENGTHS["hy3-preview"]from 256000 → 262144tests/hermes_cli/test_tencent_tokenhub_provider.pyassert ctx == 262144Why
OpenRouter's live API now reports
hy3-previewwithcontext_length: 262144(the model provider updated it after the initial 256000 launch value). Sinceget_model_context_length("hy3-preview")hits the OpenRouter metadata cache (step 6 in resolution) before the static fallback table (step 8), the function already returns 262144 in practice — the static table and test assertion were just stale.How to Test
Platforms Tested