fix(gateway): use user role for cron mirror messages to maintain message alternation - #2223
Closed
ygd58 wants to merge 3 commits into
Closed
fix(gateway): use user role for cron mirror messages to maintain message alternation#2223ygd58 wants to merge 3 commits into
ygd58 wants to merge 3 commits into
Conversation
Contributor
|
Closing — this has been superseded by recent gateway changes to cron delivery and session handling. Thanks for the contribution! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2221
Root Cause
gateway/mirror.pywas appending cron delivery messages withrole: "assistant". Since the previous message is alsorole: "assistant"(the agent's response), this created two consecutive assistant messages — violating the expected user/assistant alternation.Fix
Changed mirror message role from
"assistant"to"user"and added a[Cron delivery from {source_label}]prefix so the model understands this is an injected cron result, not a real user message.Impact