test(ci): run tests/integration in dedicated job - #22226
Closed
wesleysimplicio wants to merge 2 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds CI coverage for tests/integration/ by introducing a dedicated GitHub Actions job intended to run in parallel with existing unit (test) and end-to-end (e2e) jobs.
Changes:
- Add a new
integrationjob to.github/workflows/tests.yml. - Reuse the existing Python 3.11 +
uvsetup to runpytestagainsttests/integration/. - Set a longer timeout (25 minutes) and apply the same “empty API key” env guardrails as other test jobs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Run integration tests | ||
| run: | | ||
| source .venv/bin/activate | ||
| python -m pytest tests/integration -v --tb=short |
Comment on lines
+78
to
+86
| - name: Run integration tests | ||
| run: | | ||
| source .venv/bin/activate | ||
| python -m pytest tests/integration -v --tb=short | ||
| env: | ||
| OPENROUTER_API_KEY: "" | ||
| OPENAI_API_KEY: "" | ||
| NOUS_API_KEY: "" | ||
|
|
alt-glitch
added
type/test
Default addopts in pyproject.toml includes "-m 'not integration'", so the integration job was running 0 tests despite pointing at tests/integration. Override addopts and pass "-m integration" so the integration-marked tests actually execute. Pass repository secrets through to env vars so tests that require live API keys can run when secrets are configured; with empty secrets the job behaves as before (tests requiring live keys will skip/fail per their own guards).
Contributor
Author
|
Closing non-fix PR as requested — mantendo apenas PRs de fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
test(ci): run tests/integration in dedicated job
Root cause
The detailed rationale from the original PR body is preserved below. This template update keeps the review structure consistent with #29640.
Fix
Why this shape
tests/integration/is currently--ignored by the unit job and never run in CI, so integration regressions only surface locally or in production. Closes #22002.Tests
Original body
Related PRs / issues
Original body
Summary
test(ci): run tests/integration in dedicated job
What Changed
Fluxo
A mudança continua seguindo o fluxo original descrito na seção preservada abaixo, sem ampliar o escopo funcional deste PR.
Visão
A padronização melhora a revisão, reduz ruído e evita deriva de formatação entre PRs abertos.
Test Plan
Original body
Summary
integration:job that runstests/integration/with the same Python 3.11 + uv setup astest:ande2e:.test:ande2e:so wall-clock CI stays flat.Why
tests/integration/is currently--ignored by the unit job and never run in CI, so integration regressions only surface locally or in production. Closes #22002.Test plan
python3 -c "import yaml; yaml.safe_load(...)"parses cleanly.Generated by Hermes Turbo
Generated by Hermes Turbo