feat(gui): route embedded TUI through dashboard gateway - #21975
Closed
OutThisLife wants to merge 1 commit into
Closed
feat(gui): route embedded TUI through dashboard gateway#21975OutThisLife wants to merge 1 commit into
OutThisLife wants to merge 1 commit into
Conversation
Inject HERMES_TUI_GATEWAY_URL into dashboard PTY sessions so embedded ui-tui instances attach to the in-process websocket gateway, with coverage for the new env wiring.
Contributor
|
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HERMES_TUI_GATEWAY_URLin dashboard PTY sessions so embeddedui-tuican attach to the in-process/api/wsgateway_build_gateway_ws_url()helper and keep sidecar event fanout wiring unchanged for dashboard sidebar compatibility_resolve_chat_argvTest plan
scripts/run_tests.sh tests/hermes_cli/test_web_server.py -k "resolve_chat_argv_injects_gateway_ws_url or channel_param_propagates_sidecar_url"scripts/run_tests.sh tests/hermes_cli/test_web_server.py -k "PtyWebSocket or resolve_chat_argv_injects_gateway_ws_url"