Skip to content

feat(gui): route embedded TUI through dashboard gateway - #21975

Closed
OutThisLife wants to merge 1 commit into
bb/tui-gateway-attach-corefrom
bb/gui-gateway-attach-wiring
Closed

feat(gui): route embedded TUI through dashboard gateway#21975
OutThisLife wants to merge 1 commit into
bb/tui-gateway-attach-corefrom
bb/gui-gateway-attach-wiring

Conversation

@OutThisLife

Copy link
Copy Markdown
Collaborator

Summary

  • set HERMES_TUI_GATEWAY_URL in dashboard PTY sessions so embedded ui-tui can attach to the in-process /api/ws gateway
  • add _build_gateway_ws_url() helper and keep sidecar event fanout wiring unchanged for dashboard sidebar compatibility
  • add web-server coverage to assert gateway URL injection in _resolve_chat_argv

Test plan

  • scripts/run_tests.sh tests/hermes_cli/test_web_server.py -k "resolve_chat_argv_injects_gateway_ws_url or channel_param_propagates_sidecar_url"
  • scripts/run_tests.sh tests/hermes_cli/test_web_server.py -k "PtyWebSocket or resolve_chat_argv_injects_gateway_ws_url"

Inject HERMES_TUI_GATEWAY_URL into dashboard PTY sessions so embedded ui-tui instances attach to the in-process websocket gateway, with coverage for the new env wiring.
@github-actions

github-actions Bot commented May 8, 2026

Copy link
Copy Markdown
Contributor

⚠️ npm lockfile hash out of date

Checked against commit db84eea (PR head at check time).

The hash = "sha256-..." line in these nix files no longer matches the committed package-lock.json:

Apply the fix

  • Apply lockfile fix — tick to push a commit with the correct hashes to this PR branch
  • Or run the Nix Lockfile Fix workflow manually (pass PR #21975)
  • Or locally: nix run .#fix-lockfiles and commit the diff

@OutThisLife

Copy link
Copy Markdown
Collaborator Author

Superseded by #21978 (core TUI attach to main) and #21979 (bb/gui wiring).

@OutThisLife OutThisLife closed this May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant