fix(kanban): require verifier evidence for worker completion - #21925
Closed
camaragon wants to merge 11 commits into
Closed
fix(kanban): require verifier evidence for worker completion#21925camaragon wants to merge 11 commits into
camaragon wants to merge 11 commits into
Conversation
camaragon
force-pushed
the
fix/autonomy-verifier-gate
branch
from
May 8, 2026 15:16
7f86a93 to
82fb7ee
Compare
camaragon
force-pushed
the
fix/autonomy-verifier-gate
branch
from
May 11, 2026 13:50
c0323e5 to
ee0cd96
Compare
This was referenced May 14, 2026
fix(kanban): prevent false task completion with QC verifier scoring gate
zhanglib1996/hermes-agent#1
Closed
Contributor
|
Thanks @camaragon — closing this one. The PR proposes a substantive policy: dispatcher-spawned worker tasks would be blocked from completing without a This is a behavioral policy decision that's bigger than a mechanical salvage:
If verifier-gated completion is something we want to add, it deserves a focused, narrow PR against current main with the policy boundaries clearly specified (which tasks does it apply to, what counts as 'evidence', what's the migration story for existing workers). Appreciate the careful design work. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
completion_blocked_weak_verificationevents on weak closeskanban_completeguidance/errors so workers providemetadata.verification.checksVerification
python -m pytest tests/hermes_cli/test_kanban_core_functionality.py tests/hermes_cli/test_kanban_cli.py tests/tools/test_kanban_tools.py tests/hermes_cli/test_kanban_db.py -q -o 'addopts='→ 286 passed, 2 warningsgit diff --check→ cleanpython -m py_compile hermes_cli/kanban.py hermes_cli/kanban_db.py tools/kanban_tools.py tests/hermes_cli/test_kanban_db.py tests/hermes_cli/test_kanban_core_functionality.py tests/tools/test_kanban_tools.py→ cleanNotes