fix(skills): skill_manage create respects skills.external_dirs - #21812
Closed
sg-shag wants to merge 1 commit into
Closed
fix(skills): skill_manage create respects skills.external_dirs#21812sg-shag wants to merge 1 commit into
sg-shag wants to merge 1 commit into
Conversation
When skills.external_dirs is configured, use the first entry as the default creation root instead of hardcoded SKILLS_DIR (~/.hermes/skills/). Falls back to SKILLS_DIR when no external dirs are configured, preserving existing behavior for users without external_dirs. Fixes NousResearch#21810
alt-glitch
added
type/bug
Author
|
Closing this PR — after further exploration, we decided not to use |
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skill_manage(action='create')previously always wrote new skills to~/.hermes/skills/(hardcodedSKILLS_DIR), ignoring anyskills.external_dirsconfigured inconfig.yaml.This means users who maintain skills in a separate git repository via
external_dirshad no way to use the tool to create skills there —they had to use
write_filedirectly.Change
Added
_default_creation_root()that returns the first configuredexternal dir when
skills.external_dirsis set, falling back toSKILLS_DIRwhen it is not._resolve_skill_dir()now uses thisinstead of the hardcoded constant.
No regression: users without
external_dirsget identical behavior.Closes
Fixes #21810