fix(skills): validate frontmatter name matches directory name at write time - #21806
Open
liuhao1024 wants to merge 3 commits into
Open
fix(skills): validate frontmatter name matches directory name at write time#21806liuhao1024 wants to merge 3 commits into
liuhao1024 wants to merge 3 commits into
Conversation
…INSTALL_TIMEOUT Increase the default npm install timeout for WhatsApp bridge from 60s to 300s (5 minutes) to accommodate slower systems like Unraid NAS. Make it configurable via WHATSAPP_NPM_INSTALL_TIMEOUT environment variable for users who need even longer timeouts. Closes NousResearch#14980
- Add 'path', 'old_string', 'new_string', and 'patch' to required list - Update description to clarify mode-specific parameter requirements - This addresses issue where LLMs would omit these parameters because they were not marked as required in the schema, even though they are required depending on the mode Fixes NousResearch#15524
…e time Prevent skills whose skills_list display name diverges from the directory name used by skill_view — a silent data-corruption bug that makes skills undiscoverable. Both _create_skill() and _edit_skill() now parse the YAML frontmatter and reject content whose 'name' field does not match the directory name parameter. This is a write-path complement to the read-path fallback added in PR NousResearch#18901. Fixes NousResearch#21782
Contributor
|
Thanks for identifying the write-time namespace invariant; it is still absent on current main. The original discoverability symptom is mitigated by the later frontmatter-name lookup in Problems
Suggested changes
This is an automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
_create_skill()and_edit_skill()silently accept content whose frontmatternamediffers from thenameparameter (the directory name). This creates skills whoseskills_listdisplay name diverges from the directory name used byskill_view(), making them permanently undiscoverable.Root Cause
Neither
_create_skill()nor_edit_skill()validates that the YAML frontmatternamefield matches thenameparameter. The write path accepts any valid frontmatter, creating a directory named after thenameparameter while storing a differentnamein the SKILL.md frontmatter.skills_list()→ returns frontmattername(e.g.,local-paper-summary)skill_view("local-paper-summary")→ resolves by directory name → not foundRelated Issue
N/A
Type of Change
Changes Made
How to Test
pytest tests/ -q— all tests should passChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture and workflows — or N/A