fix: recognize current Hermes Ink bundle artifact - #21646
Closed
dontcallmejames wants to merge 1 commit into
Closed
Conversation
Collaborator
Contributor
Author
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@hermes/inkbuild artifact,dist/entry-exports.js, when deciding whether the TUI bundle is staledist/ink-bundle.jsfallback for older buildsWhy
The dashboard Chat tab opens
/api/ptyand calls the TUI build/staleness check before spawning the PTY child. The current Ink build outputsentry-exports.js, but the stale check only looked forink-bundle.js, so Hermes considered the bundle missing and attempted to rebuild on every WebSocket open. On slower machines this can block the WebSocket handshake long enough for the browser to report that the session ended / WebSocket connection failed.Test Plan
python -m pytest tests/hermes_cli/test_tui_npm_install.py -q