Skip to content

fix: recognize current Hermes Ink bundle artifact - #21646

Closed
dontcallmejames wants to merge 1 commit into
NousResearch:mainfrom
dontcallmejames:fix/tui-ink-bundle-stale
Closed

fix: recognize current Hermes Ink bundle artifact#21646
dontcallmejames wants to merge 1 commit into
NousResearch:mainfrom
dontcallmejames:fix/tui-ink-bundle-stale

Conversation

@dontcallmejames

Copy link
Copy Markdown
Contributor

Summary

  • Recognize the current @hermes/ink build artifact, dist/entry-exports.js, when deciding whether the TUI bundle is stale
  • Keep the legacy dist/ink-bundle.js fallback for older builds
  • Add regression coverage for both current and legacy bundle artifact names

Why

The dashboard Chat tab opens /api/pty and calls the TUI build/staleness check before spawning the PTY child. The current Ink build outputs entry-exports.js, but the stale check only looked for ink-bundle.js, so Hermes considered the bundle missing and attempted to rebuild on every WebSocket open. On slower machines this can block the WebSocket handshake long enough for the browser to report that the session ended / WebSocket connection failed.

Test Plan

  • python -m pytest tests/hermes_cli/test_tui_npm_install.py -q

@alt-glitch alt-glitch added type/bug Something isn't working comp/cli CLI entry point, hermes_cli/, setup wizard comp/tui Terminal UI (ui-tui/ + tui_gateway/) P2 Medium — degraded but workaround exists duplicate This issue or pull request already exists labels May 8, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Duplicate of #20322. This is the same ink-bundle.js → entry-exports.js filename fix already addressed by #20322 and its superset #20686. See also #20951, #21098, #21630.

@dontcallmejames

Copy link
Copy Markdown
Contributor Author

Thanks for the pointer — confirmed this duplicates #20322 / #20686 and the newer #21630. Closing this one to keep the queue clean.

@dontcallmejames

Copy link
Copy Markdown
Contributor Author

Closing as duplicate of #20322 / #20686 / #21630.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard comp/tui Terminal UI (ui-tui/ + tui_gateway/) duplicate This issue or pull request already exists P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants