Skip to content

fix(tui): update _hermes_ink_bundle_stale to check for entry-exports.js #21630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fiikf wants to merge 1 commit into from
Closed

fix(tui): update _hermes_ink_bundle_stale to check for entry-exports.js #21630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hermes_cli/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -972,7 +972,7 @@ def _tui_build_needed(tui_dir: Path) -> bool:

def _hermes_ink_bundle_stale(tui_dir: Path) -> bool:
ink_root = tui_dir / "packages" / "hermes-ink"
bundle = ink_root / "dist" / "ink-bundle.js"
bundle = ink_root / "dist" / "entry-exports.js"
if not bundle.exists():
return True
bm = bundle.stat().st_mtime
Expand Down
2 changes: 1 addition & 1 deletion tests/hermes_cli/test_tui_npm_install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def _touch_tui_entry(root: Path) -> None:


def _touch_ink_bundle(root: Path) -> None:
bundle = root / "packages" / "hermes-ink" / "dist" / "ink-bundle.js"
bundle = root / "packages" / "hermes-ink" / "dist" / "entry-exports.js"
bundle.parent.mkdir(parents=True, exist_ok=True)
bundle.write_text("export {}")

Expand Down