docs(security): fix secret redaction default docs - #21621
Closed
helix4u wants to merge 2 commits into
Closed
Conversation
helix4u
marked this pull request as ready for review
May 8, 2026 02:10
Contributor
|
This is already implemented on current Automated hermes-sweeper review evidence:
Thanks for catching and fixing the docs drift. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates stale documentation that still described
security.redact_secretsas disabled by default.Hermes now defaults secret redaction on, so this PR aligns the configuration guide, bundled Hermes-agent skill source and generated skill page, and the
agent.redacthelper docstring with the current default.Related Issue
Docs drift from #17691 / #20785.
Type of Change
Changes Made
website/docs/user-guide/configuration.mdto showredact_secrets: trueas the default and explain when to disable it.skills/autonomous-ai-agents/hermes-agent/SKILL.mdso the source skill no longer tells agents that redaction is off by default.website/docs/user-guide/skills/bundled/autonomous-ai-agents/autonomous-ai-agents-hermes-agent.mdto match the source skill.agent/redact.pyhelper docstring to match the current default.How to Test
git diff --checkChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
N/A.
Screenshots / Logs
git diff --checkpassed.