fix: forward reference images through Codex and native FAL image generation - #21570
Closed
jplew wants to merge 6 commits into
Closed
fix: forward reference images through Codex and native FAL image generation#21570jplew wants to merge 6 commits into
jplew wants to merge 6 commits into
Conversation
Collaborator
This was referenced May 14, 2026
# Conflicts: # plugins/image_gen/openai-codex/__init__.py # tests/plugins/image_gen/test_openai_codex_provider.py
Contributor
Author
|
I updated the PR to reconcile it with main's recent adoption of httpx+SSE architecture |
jplew
force-pushed
the
reference-images-for-image-gen
branch
from
June 4, 2026 06:38
d6a93d5 to
d8a2dee
Compare
Contributor
Author
|
fixed on another PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds end-to-end
reference_imagesforwarding for both major Hermes image-generation paths covered by this branch:Before this change, Hermes could accept
reference_imagesat the tool layer, but backend handling was incomplete:After this change:
reference_imagesare accepted byimage_generateimage_urlsThis was tested specifically against:
Related Issue
Closes #21562
Type of Change
Changes Made
tools/image_generation_tool.pyreference_imagessupport toimage_generate_tool(...)reference_imagesfrom_handle_image_generate(...)_normalize_fal_reference_images(...)data:image/...URLs, and local file pathsfal-ai/nano-banana-pro/editfal-ai/nano-banana-2/editplugins/image_gen/openai-codex/__init__.pytests/tools/test_image_generation.pyimage_sizereference_imagesimage_urlsforwardingtests/tools/test_image_generation_tool_reference_images.pytests/plugins/image_gen/test_openai_codex_provider.pyHow to Test
Run:
Configure Hermes to use either:
Submit an image-edit request with:
Confirm the backend receives real image refs and the result preserves composition while changing identity.
Runtime Verification
This branch was validated with focused tests and with live runtime verification on native FAL/Nano Banana Pro using two references.
The live Hermes session confirmed that:
reference_imagesChecklist
Code
fix(scope):,feat(scope):, etc.)Documentation & Housekeeping