fix: honor opencode-go max reasoning effort - #21501
Closed
danshapiro wants to merge 1 commit into
Closed
Conversation
Accept max as a reasoning effort level and have the opencode-go provider profile send deepseek-v4 reasoning_effort as a top-level Chat Completions parameter. Add provider-profile, transport-profile, and gateway command regression coverage.
danshapiro
force-pushed
the
yente/opencode-go-max-reasoning-upstream-pr
branch
from
May 7, 2026 20:24
217e382 to
2f37a02
Compare
Contributor
|
Thanks for the focused OpenCode Go regression coverage. The provider/config portion of this change is already present on current main, but the gateway command portion remains useful and needs a manual salvage. Problems
Suggested changes
This is an automated hermes-sweeper review. |
Contributor
|
Closing — fully superseded on current main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maxas a reasoning effort level in config and gateway command handlingopencode-goprovider profile senddeepseek-v4-*reasoning effort as a top-level Chat Completionsreasoning_effortparameterextra_body.reasoningfor the DeepSeek V4 profile pathTests
uv run --frozen --extra dev pytest tests/providers/test_provider_profiles.py::TestOpenCodeGoProfile tests/providers/test_transport_parity.py::TestOpenCodeGoParity tests/gateway/test_reasoning_command.py::TestReasoningCommand::test_parse_reasoning_command_args_accepts_ascii_and_smart_global_flagsuv run --frozen --extra dev pytest tests/providers/test_provider_profiles.py tests/providers/test_transport_parity.py tests/gateway/test_reasoning_command.pygit diff --check