fix(kanban): filter dashboard board by selected tenant (#19817) - #21349
Merged
Conversation
Contributor
🔎 Lint report:
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tenant dropdown on the Kanban dashboard now actually filters the rendered cards instead of only filtering what the API returned.
Salvage of @maciekczech's PR #19817 onto current main.
Root cause
filterTaskinfilteredBoard(plugins/kanban/dashboard/dist/index.js) checkedassigneeFilterandsearchbut nottenantFilter. Meanwhile theuseMemodeps list didn't includetenantFiltereither. Net effect: tenant-switching would update the URL's?tenant=param on the next API fetch, but between fetches (and on the cached client-side view), cards from other tenants stayed visible.Fix
Two one-liners in
plugins/kanban/dashboard/dist/index.js:if (tenantFilter && t.tenant !== tenantFilter) return false;tofilterTask.tenantFilterto theuseMemodeps array.Validation
Live browser E2E against a real dashboard with 3 tasks across 2 tenants:
Tests:
tests/plugins/test_kanban_dashboard_plugin.py— 70 passed (68 existing + 2 new from the PR).onValueChangewiring and the tenant-aware client-side filtering.Closes