Skip to content

fix(kanban): filter dashboard board by selected tenant (#19817) - #21349

Merged
teknium1 merged 3 commits into
mainfrom
hermes/hermes-26a2390d
May 7, 2026
Merged

fix(kanban): filter dashboard board by selected tenant (#19817)#21349
teknium1 merged 3 commits into
mainfrom
hermes/hermes-26a2390d

Conversation

@teknium1

@teknium1 teknium1 commented May 7, 2026

Copy link
Copy Markdown
Contributor

Tenant dropdown on the Kanban dashboard now actually filters the rendered cards instead of only filtering what the API returned.

Salvage of @maciekczech's PR #19817 onto current main.

Root cause

filterTask in filteredBoard (plugins/kanban/dashboard/dist/index.js) checked assigneeFilter and search but not tenantFilter. Meanwhile the useMemo deps list didn't include tenantFilter either. Net effect: tenant-switching would update the URL's ?tenant= param on the next API fetch, but between fetches (and on the cached client-side view), cards from other tenants stayed visible.

Fix

Two one-liners in plugins/kanban/dashboard/dist/index.js:

  • Add if (tenantFilter && t.tenant !== tenantFilter) return false; to filterTask.
  • Add tenantFilter to the useMemo deps array.

Validation

Live browser E2E against a real dashboard with 3 tasks across 2 tenants:

Selection Cards rendered
All tenants alpha-task, beta-task, gamma-task (3/3)
alpha alpha-task, gamma-task (2/2 alpha tasks; Ready badge = 2)
beta beta-task (1/1 beta task)

Tests:

  • tests/plugins/test_kanban_dashboard_plugin.py70 passed (68 existing + 2 new from the PR).
  • New regression tests cover both the SDK Select onValueChange wiring and the tenant-aware client-side filtering.

Closes

@teknium1
teknium1 merged commit bbff2f6 into main May 7, 2026
10 of 11 checks passed
@teknium1
teknium1 deleted the hermes/hermes-26a2390d branch May 7, 2026 14:40
@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

🔎 Lint report: hermes/hermes-26a2390d vs origin/main

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 7632 on HEAD, 7632 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 4008 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/plugins Plugin system and bundled plugins labels May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants