Skip to content

test(docker): align Dockerfile contract tests with simplified TUI flow (salvage #19024) #21174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teknium1 merged 1 commit into from
May 7, 2026
Merged

test(docker): align Dockerfile contract tests with simplified TUI flow (salvage #19024) #21174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 19 additions & 11 deletions tests/tools/test_dockerfile_pid1_reaping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,15 @@ def test_dockerfile_entrypoint_routes_through_the_init(dockerfile_text):


def test_dockerfile_installs_tui_dependencies(dockerfile_text):
# The TUI workspace manifests must be present so ``npm install`` can
# resolve dependencies. The bundled ``hermes-ink`` workspace package is
# now COPIED into the image as a whole tree (not just its lockfile)
# because it's referenced as a ``file:`` workspace dependency from
# ``ui-tui/package.json`` — copying the tree avoids npm stopping at a
# bare ``package.json`` shell.
assert "ui-tui/package.json" in dockerfile_text
assert "ui-tui/packages/hermes-ink/package-lock.json" in dockerfile_text
assert "ui-tui/package-lock.json" in dockerfile_text
assert "ui-tui/packages/hermes-ink/" in dockerfile_text
assert any(
"ui-tui" in step and "npm" in step and (" install" in step or " ci" in step)
for step in _run_steps(dockerfile_text)
Expand All @@ -122,16 +129,17 @@ def test_dockerfile_builds_tui_assets(dockerfile_text):


def test_dockerfile_materializes_local_tui_ink_package(dockerfile_text):
assert any(
"ui-tui" in step
and "node_modules/@hermes/ink" in step
and "packages/hermes-ink" in step
and "rm -rf packages/hermes-ink/node_modules" in step
and "npm install --omit=dev" in step
and "--prefix node_modules/@hermes/ink" in step
and "rm -rf node_modules/@hermes/ink/node_modules/react" in step
and "await import('@hermes/ink')" in step
for step in _run_steps(dockerfile_text)
# ``hermes-ink`` is a bundled workspace package referenced from
# ``ui-tui/package.json`` via ``file:`` — not pulled from the npm
# registry. The contract this test pins is just that the image
# actually carries the package source so ``await import('@hermes/ink')``
# can resolve at runtime; the previous, much pickier assertion (manual
# ``rm -rf`` + ``npm install --omit=dev --prefix node_modules/@hermes/ink``)
# baked in implementation details of an older materialisation flow that
# was simplified once npm workspaces handled the resolution natively.
assert "ui-tui/packages/hermes-ink/" in dockerfile_text, (
"Dockerfile must COPY the bundled hermes-ink workspace package "
"so ``await import('@hermes/ink')`` resolves at runtime."
)


Expand Down
Loading