Skip to content

fix(gateway): log platform status write failures instead of silently … #21158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wabrent wants to merge 1 commit into from
Closed

fix(gateway): log platform status write failures instead of silently … #21158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions gateway/platforms/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1307,8 +1307,8 @@ def _mark_connected(self) -> None:
try:
from gateway.status import write_runtime_status
write_runtime_status(platform=self.platform.value, platform_state="connected", error_code=None, error_message=None)
except Exception:
pass
except Exception as exc:
logger.warning("Failed to write runtime status (connected) for %s: %s", self.platform.value, exc)

def _mark_disconnected(self) -> None:
self._running = False
Expand All @@ -1317,8 +1317,8 @@ def _mark_disconnected(self) -> None:
try:
from gateway.status import write_runtime_status
write_runtime_status(platform=self.platform.value, platform_state="disconnected", error_code=None, error_message=None)
except Exception:
pass
except Exception as exc:
logger.warning("Failed to write runtime status (disconnected) for %s: %s", self.platform.value, exc)

def _set_fatal_error(self, code: str, message: str, *, retryable: bool) -> None:
self._running = False
Expand All @@ -1333,8 +1333,8 @@ def _set_fatal_error(self, code: str, message: str, *, retryable: bool) -> None:
error_code=code,
error_message=message,
)
except Exception:
pass
except Exception as exc:
logger.warning("Failed to write runtime status (fatal) for %s: %s", self.platform.value, exc)

async def _notify_fatal_error(self) -> None:
handler = self._fatal_error_handler
Expand Down