fix(compression): pass continuity advisory into compressor input - #21118
fix(compression): pass continuity advisory into compressor input#21118stefan-mcf wants to merge 1 commit into
Conversation
|
Thanks for identifying the unconsumed Problems
Suggested changes
Automated hermes-sweeper review. |
|
This fix has landed on main via PR #67938 (salvaged from PR #64342 by @GottZ, which consolidated the on_pre_compress return-value forwarding with sanitization, engine-signature compatibility, and lock hardening). Your PR correctly identified the same root cause — the provider's return value being silently discarded before compression. The merged implementation supersedes this one, so closing it. First-submitter credit goes to @jairodriguez (#11236, Apr 16); thank you for the independent confirmation and fix. |
Summary
Why
This is a separate Hermes-side compression continuity improvement. Some memory/context providers can supply advisory continuity text before compression. Hermes should make that text available to the compressor input while keeping the live transcript unchanged and while treating provider hook failures as non-fatal.
This PR is intentionally separate from delegation/subagent truncation hardening so each change has a single root-cause story.
Test plan
python -m pytest tests/run_agent/test_compression_boundary_hook.py -q -k 'ContinuityAdvisory or compression_boundary'