Use default input sample rate for voice recording - #20788
Closed
bricelb wants to merge 1 commit into
Closed
Conversation
12 tasks
Contributor
Author
|
Superseded by #61463 — same fix rebased on current main, with tests added per the contributing guide. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the default input device sample rate for voice recording instead of forcing 16 kHz.
Why
Some audio devices do not support opening an input stream at 16 kHz directly. On those systems, voice recording can fail even though the input device exposes a usable native sample rate such as 44.1 kHz or 48 kHz.
Changes
default_sampleratebefore opening the stream.InputStream, short-recording threshold calculation, and WAV metadata.Validation
python3 -m py_compile tools/voice_mode.pygit diff --check