fix(gateway): stop typing before sending response to prevent race condition - #20780
Open
doskey wants to merge 1 commit into
Open
fix(gateway): stop typing before sending response to prevent race condition#20780doskey wants to merge 1 commit into
doskey wants to merge 1 commit into
Conversation
alt-glitch
added
type/bug
This was referenced May 7, 2026
This was referenced May 14, 2026
teknium1
added
the
sweeper:blast-moderate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After sending a response on Telegram, the typing indicator can re-appear because _keep_typing may fire another typing before _stop_typing_task() cancels it in the finally block. Fix: pause typing via pause_typing_for_chat() right before _send_with_retry.