test(gateway): add webhook toolset regression coverage - #20731
Closed
dlkakbs wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thanks for the follow-up — closing as redundant. The exact wiring this file pins is already covered generically by
So the original failure mode (webhook platform registered without its toolset, or missing from the gateway bundle) already fails the existing generic suite. Adding a webhook-named duplicate doesn't give us additional regression coverage — it just doubles the assertion surface for one platform while every other platform rides on the generic check. Appreciate the diligence on the #3775 → #4363 → #4660 chain — the runtime wiring is landed and guarded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds explicit regression coverage for the webhook platform/toolset wiring that previously caused
KeyErrorfailures on webhook-triggered agent runs.This PR verifies that:
hermes-webhookis defined and validates as a toolsetwebhookplatform resolves todefault_toolset="hermes-webhook"hermes_cli.tools_config.PLATFORMSexports the same mappinghermes-gatewaystill includeshermes-webhookContext
This is a focused test-only follow-up to earlier webhook platform registration work.
Related history:
mainWhat landed on
mainfrom that chain was the runtime/config wiring:hermes-webhooktoolset registrationhermes-gatewayWhat did not land was the dedicated regression coverage from #3775.
This PR adds that missing explicit test coverage only, without changing runtime behavior.
Why this is still useful
mainalready has broader platform/toolset consistency coverage, but this PR adds a webhook-specific regression test for the exact wiring that was previously missing and that motivated #3775.That makes the original failure mode easier to catch directly if webhook registration regresses again.