fix(slack): tighten strict mention routing - #20726
Closed
Claude-Kimn wants to merge 6 commits into
Closed
Conversation
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improves Slack channel/thread routing for strict mention mode and nudges non-tool empty model responses to produce a short visible answer before giving up.
This carries the AI-5142 production hotfixes onto the current
mainbranch so deployments can be reproduced from source instead of a server-only runtime branch.Related Issue
Fixes #8019
Type of Change
Changes Made
gateway/platforms/slack.pymention_patternsto count as explicit Slack calls, including instrict_mentionmodegateway/config.pymention_patternsinto platform extra config/envrun_agent.pyhermes_cli/commands.py/hermes-statusto Hermes commandstests/run_agent/test_run_agent.pyHow to Test
require_mention: true,strict_mention: true, andmention_patternsfor a bot name.@botand configured name calls route to the bot.Tested:
Local macOS clone did not have pytest installed; the test command above was run in the Hermes runtime venv on Linux.
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
N/A
Screenshots / Logs
Production symptoms addressed: