chore(kanban): tier-2 medium bug-fix batch - #20706
Closed
teknium1 wants to merge 7 commits into
Closed
Conversation
The Nous DS globals.css applies a global rule:
code { background: var(--midground); color: var(--background); }
This paints an opaque cream/yellow fill on every <code> element,
which hides text in the kanban drawer's event-payload, run-meta,
and worker-log panes (all rendered as <code>).
Fix: scope a reset inside .hermes-kanban so <code> elements inherit
their parent's color and stay transparent.
1 task
Contributor
Author
|
Closing as superseded — all four sub-PRs in this batch (#19475, #19817, #20508, #18518) are already closed via other paths since this batch was opened. The Codex preflight (#19475) and send_kanban_blocked (#20508) substance may still be missing from main and worth a fresh focused PR if needed; the tenant-filter client-side change appears applied already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three contributor bug fixes salvaged onto current main, authorship preserved via rebase-merge. A fourth (#18518) verified as already on main and will be closed with credit, not re-merged.
What changed
send_kanban_blockedhelper on TelegramAdapter (resolves #20263)Plus AUTHOR_MAP entry for @maciekczech.
Root causes + fixes
#19475 — Codex profile auth preflight. Kanban workers dispatched under an assignee whose profile is configured for
openai-codexbut has no profile-local auth.json would spawn successfully, exit immediately on provider validation, then re-enter the dispatch loop via the failure counter. New_preflight_worker_profile_authreads only non-secret metadata (config.yaml provider + auth.json presence/size) and fails the dispatch with a clear error pointing athermes -p <profile> auth. Scoped toopenai-codexvia_AUTH_STORE_REQUIRED_PROVIDERS; extensible when other OAuth providers show the same pattern.#19817 — tenant filter client-side gap. The dashboard already sends
?tenant=Xto the API, but the client-sidefilterTaskfunction insideuseMemo(filteredBoard)only checkedassigneeFilterand search. Switching tenants left stale cards visible until a full reload finished. Two-line fix: add tenant predicate + tenant to the useMemo dep array. Two bundle-inspection tests added to prevent regression.#20508 — TG adapter API drift. @leonardsellem's homelab guardrails plugin calls
TelegramAdapter.send_kanban_blockedwhich we never shipped, forcing downstreamgetattrdefense. Adds a small delegator that formats a⏸ Kanban <id> blocked: <reason>message and routes through the standardsend()path. Accepts both positional and dict-shaped task args for forward-compat.Validation
has_spawnable_ready()(landed post-PR-branch-point); resolved by keeping both.