Replace cumulative Hindsight transcript snapshots - #20664
Closed
discolotus wants to merge 1 commit into
Closed
Conversation
discolotus
marked this pull request as ready for review
May 6, 2026 10:55
Contributor
|
This looks implemented on current main by a later Hindsight fix. Automated hermes-sweeper review. Evidence:
Main uses a different implementation than this PR proposed: it keeps the stable session-scoped append document and sends deltas, rather than switching modern APIs to per-process replace. That still resolves the reported duplication/unbounded-growth behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update_mode=appendon the session document toupdate_mode=replaceon the per-process documentupdate_modewhen unsupportedRationale
Hermes builds each auto-retain payload from the full in-process session buffer. Appending those cumulative snapshots duplicates earlier turns on every retain. Replacing the per-process snapshot preserves the current process lifecycle transcript without risking a restart overwriting a prior process lifecycle.
Testing
/Users/tleo/.hermes/hermes-agent/venv/bin/python -m pytest tests/plugins/memory/test_hindsight_provider.py -q/Users/tleo/.hermes/hermes-agent/venv/bin/python -m py_compile plugins/memory/hindsight/__init__.py run_agent.py gateway/run.py tests/plugins/memory/test_hindsight_provider.py