fix(cron): support Telegram topic delivery via platform:chat_id:thread_id format - #2037
Closed
alexferrari88 wants to merge 1 commit into
Closed
alexferrari88 wants to merge 1 commit into
alexferrari88 wants to merge 1 commit into
Conversation
alexferrari88
force-pushed
the
fix/cron-telegram-topic-delivery
branch
2 times, most recently
from
March 20, 2026 04:31
648a9c8 to
6207786
Compare
Contributor
Author
|
the failing tests are not related to my PR |
5 tasks
alexferrari88
force-pushed
the
fix/cron-telegram-topic-delivery
branch
from
March 21, 2026 06:14
6207786 to
6464702
Compare
Contributor
Author
|
rebased and conflict resolved |
…d_id format Parse thread_id from explicit deliver target (e.g. telegram:-1003724596514:17) and forward it to _send_to_platform and mirror_to_session. Previously _resolve_delivery_target() always set thread_id=None when parsing the platform:chat_id format, breaking cron job delivery to specific Telegram topics. Added tests: - test_explicit_telegram_topic_target_with_thread_id - test_explicit_telegram_chat_id_without_thread_id Also updated CRONJOB_SCHEMA deliver description to document the platform:chat_id:thread_id format.
alexferrari88
force-pushed
the
fix/cron-telegram-topic-delivery
branch
from
March 22, 2026 06:21
6464702 to
3a520ba
Compare
Contributor
Author
|
rebased onto the latest main on remote |
Collaborator
|
Merged via PR #2455. Your commit was cherry-picked onto current main with authorship preserved. Clean fix — the negative chat ID handling via split(':', 1) was nicely done. Thanks @alexferrari88! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The current implementation prevents cron job to send Telegram messages to Topics inside Telegram groups.
Solution
Parse
thread_idfrom explicitdelivertarget (e.g.telegram:-1003724596514:17) in_resolve_delivery_target()and forward it to_send_to_platformandmirror_to_session.Previously
_resolve_delivery_target()always setthread_id=Nonewhen parsing theplatform:chat_idformat, breaking cron job delivery to specific Telegram topics.Changes
:thread_idsuffix when present in deliver targetCRONJOB_SCHEMAdeliverdescription to document theplatform:chat_id:thread_idformatTesting