fix: prevent command injection in quick commands and shell.exec - #20333
Closed
0z1-ghb wants to merge 7 commits into
Closed
fix: prevent command injection in quick commands and shell.exec#203330z1-ghb wants to merge 7 commits into
0z1-ghb wants to merge 7 commits into
Conversation
Use shlex.split and shell=False to prevent shell metacharacter injection.
Collaborator
Contributor
Author
|
Thanks for the heads up. I see #10698 covers the same fix. I'll close this to avoid duplication |
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
shell=Truewithshell=False+shlex.split()in three locations:cli.py— quick command executiontui_gateway/server.py— quick command executiontui_gateway/server.py—shell.execJSON-RPC methodSecurity Impact
Using
shell=Trueallows shell metacharacter injection. If an attacker can write toconfig.yaml(viafile_writetool, malicious skill/plugin, or config injection), they can execute arbitrary commands: