fix(cron): propagate pre-run script failure to job status

[liuhao1024]

What does this PR do?

When a cron job's pre-run script exits non-zero, the error is injected into the agent prompt — but run_job() still reports success (status=ok). Operators see ok and assume the job ran correctly, when the data-collection step actually failed.

Root Cause

In run_job(), the pre-run script result (_ran_ok) is only used to build the prompt content. The function always returns True at the end, regardless of whether the script succeeded or failed.

Related Issue

N/A

Type of Change

• 🐛 Bug fix (non-breaking change that fixes an issue)

Changes Made

• See commit messages for detailed changes

How to Test

1. Run pytest tests/ -q — all tests should pass
2. Verify the specific scenario described above is resolved

Checklist

Code

• I've read the Contributing Guide
• My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
• I searched for existing PRs to make sure this isn't a duplicate
• My PR contains only changes related to this fix/feature (no unrelated commits)
• I've run pytest tests/ -q and all tests pass
• I've added tests for my changes (required for bug fixes, strongly encouraged for features)
• I've tested on my platform: macOS 26.4.1

Documentation & Housekeeping

• I've updated relevant documentation (README, docs/, docstrings) — or N/A
• I've updated cli-config.yaml.example if I added/changed config keys — or N/A
• I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture and workflows — or N/A
• I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A

[teknium1]

Thanks for tracking the cron status mismatch. The underlying bug is still present on current main: cron/scheduler.py:2632 receives a failed script result, while cron/scheduler.py:3244-3245 still returns success after an otherwise successful agent response.

Problems

• The proposed return not _script_failed, output, final_response, None drops the failure detail. _process_job() builds failed-job delivery from error at cron/scheduler.py:3448, and mark_job_run() persists it as last_error at cron/jobs.py:1392-1394; this would yield an unknown-error delivery and no stored script failure.
• The branch also includes unrelated changes. 6ef568c adds WHATSAPP_NPM_INSTALL_TIMEOUT as user-facing behavioral config, while AGENTS.md:102-107 requires config.yaml. 5dc3423 globally requires mutually exclusive patch-mode fields; current main intentionally keeps only mode globally required (tools/file_tools.py:2092, tests/tools/test_file_tools.py:607-613).

Suggested changes

• Keep the focused cron fix, return a non-empty error derived from the script failure, and assert that error in the regression test.
• Split/drop the unrelated WhatsApp and PATCH_SCHEMA commits.

Automated hermes-sweeper review.