Skip to content

fix(kanban): include default profile in on-disk assignee enumeration (salvages #20123) - #20170

Merged
teknium1 merged 1 commit into
mainfrom
hermes/hermes-9ddf5187
May 5, 2026
Merged

fix(kanban): include default profile in on-disk assignee enumeration (salvages #20123)#20170
teknium1 merged 1 commit into
mainfrom
hermes/hermes-9ddf5187

Conversation

@teknium1

@teknium1 teknium1 commented May 5, 2026

Copy link
Copy Markdown
Contributor

The implicit default profile now shows up in Kanban's on-disk profile enumeration, so dashboard assignee pickers and known_assignees() no longer report it as on_disk: false.

Salvaged from #20123 (@Interstellar-code).

Root cause: list_profiles_on_disk() only enumerated directories under <root>/profiles/<name>/config.yaml. The default profile lives at the Hermes root itself (~/.hermes), not under a profiles/default/ subdirectory, so it fell through the filter even though it's a real runnable profile.

Changes

  • hermes_cli/kanban_db.py: list_profiles_on_disk() now adds "default" to the result when the default Hermes root exists. Named-profile enumeration under <root>/profiles/<name>/config.yaml is unchanged.
  • Tests updated for standard and custom HERMES_HOME roots.

Validation

Before After
Dashboard assignee list with default profile present default: on_disk=False (confusing, hides a real option) default: on_disk=True
test_kanban_core_functionality.py - 119/119 pass
Broader kanban suite - 335/335 pass (test_kanban_{db,cli,boards,core_functionality} + test_kanban_tools + test_kanban_dashboard_plugin)

Closes #20123

Co-authored-by: Interstellar-code 33978413+Interstellar-code@users.noreply.github.com

@teknium1
teknium1 merged commit 542e06c into main May 5, 2026
10 of 11 checks passed
@teknium1
teknium1 deleted the hermes/hermes-9ddf5187 branch May 5, 2026 11:25
@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/plugins Plugin system and bundled plugins comp/cli CLI entry point, hermes_cli/, setup wizard labels May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants