fix(kanban): include default profile in on-disk assignee enumeration (salvages #20123) - #20170
Merged
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implicit
defaultprofile now shows up in Kanban's on-disk profile enumeration, so dashboard assignee pickers andknown_assignees()no longer report it ason_disk: false.Salvaged from #20123 (@Interstellar-code).
Root cause:
list_profiles_on_disk()only enumerated directories under<root>/profiles/<name>/config.yaml. The default profile lives at the Hermes root itself (~/.hermes), not under aprofiles/default/subdirectory, so it fell through the filter even though it's a real runnable profile.Changes
hermes_cli/kanban_db.py:list_profiles_on_disk()now adds"default"to the result when the default Hermes root exists. Named-profile enumeration under<root>/profiles/<name>/config.yamlis unchanged.HERMES_HOMEroots.Validation
default: on_disk=False(confusing, hides a real option)default: on_disk=Truetest_kanban_core_functionality.pytest_kanban_{db,cli,boards,core_functionality}+test_kanban_tools+test_kanban_dashboard_plugin)Closes #20123
Co-authored-by: Interstellar-code 33978413+Interstellar-code@users.noreply.github.com