Fix AES key decoding issue with WeCom API response - #20097
Closed
wenjon wants to merge 1 commit into
Closed
Conversation
…ring (missing the = padding character). Directly using base64.b64decode() will result in an 'Incorrect padding' error, preventing the image from being decrypted
Collaborator
Collaborator
|
Duplicate of #14580. |
Contributor
|
This looks implemented on main now. Automated hermes-sweeper review evidence:
Thanks for the report and patch; the same fix has already landed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ring (missing the = padding character). Directly using base64.b64decode() will result in an 'Incorrect padding' error, preventing the image from being decrypted
What does this PR do?
Fix the issue where Hermes cannot decrypt images sent via WeCom (企业微信). WeCom returns aeskey as Base64-encoded but missing padding (43 chars instead of 44), causing base64.b64decode() to throw Incorrect padding error. The exception is caught and the image is skipped, making Hermes reply “没有看到图片”.
Related Issue
Fixes #
Type of Change
Changes Made
gateway/platforms/wecom.py - _decrypt_file_bytes function (~line 1018)
Before
key_bytes = base64.b64decode(aeskey)
After
key_bytes = base64.b64decode(aeskey + '=' * (-len(aeskey) % 4))
How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
Failed to decrypt image from URL: Incorrect padding


Empty WeCom message skipped
issue Screenshot
fixed Screenshot