docs(web_tools): correct web_extract summarizer timeout comment - #20051
Closed
beardthelion wants to merge 1 commit into
Closed
docs(web_tools): correct web_extract summarizer timeout comment#20051beardthelion wants to merge 1 commit into
beardthelion wants to merge 1 commit into
Conversation
The comment at tools/web_tools.py:700-702 stated the runtime default for auxiliary.web_extract.timeout is 360s. The actual runtime default is 30s (_DEFAULT_AUX_TIMEOUT in agent/auxiliary_client.py:3140), used by _get_task_timeout when no auxiliary.web_extract.timeout key is present in config.yaml. The 360s figure is the config template default written by hermes_cli/config.py:697 into freshly-generated config.yaml files. It only takes effect when that key exists in the user's config — not as a fallback. Users on configs that predate commit 20b4060 (Apr 5, 2026), or who removed the key, fall through to the 30s _DEFAULT_AUX_TIMEOUT runtime default. The comment was introduced in 20b4060 alongside the template-default bump from 30 to 360. The runtime default in auxiliary_client.py was not changed in that commit and has remained 30s since 839d9d7 (Mar 28, 2026).
alt-glitch
added
type/docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Corrects an inaccurate comment at
tools/web_tools.py:700-702describing the timeout behavior for the web_extract LLM summarization call.The current comment states the default is "360s / 6min". This is wrong:
auxiliary.web_extract.timeoutis absent from config.yaml: 30s (_DEFAULT_AUX_TIMEOUTinagent/auxiliary_client.py:3140, applied by_get_task_timeoutat line 3157).hermes_cli/config.py:697).Two different defaults in two different files. The comment confuses them. Users with slow local models who read this comment believe they have 6 minutes when they actually have 30s, leading to mystery timeouts.
Related Issue
No issue filed; surfaced while investigating
web_extracttimeout behavior on a slow local-model deployment.Type of Change
Changes Made
tools/web_tools.py:700-702— replaced the comment with one that describes both code paths accurately and points users to the correct config key.How to Test
This is a comment-only change with no behavior modification. Verification that the comment is now accurate:
grep -n '_DEFAULT_AUX_TIMEOUT' agent/auxiliary_client.py→_DEFAULT_AUX_TIMEOUT = 30.0at line 3140.grep -A1 'web_extract' hermes_cli/config.py | grep timeout→ template default360.auxiliary.web_extract.timeoutkey inconfig.yaml,_get_task_timeout("web_extract")returns 30.0 (falls through to_DEFAULT_AUX_TIMEOUT).Background
The comment was introduced in commit
20b4060d("fix: web_extract fast-fail on scrape timeout + summarizer resilience", Apr 5 2026). That commit bumped the config template default from 30 to 360 inhermes_cli/config.pybut did not touch_DEFAULT_AUX_TIMEOUTinagent/auxiliary_client.py, which had been set to 30.0 since839d9d74(Mar 28 2026). The comment was written against the new template default rather than the runtime fallback.Checklist
Code
docs(scope):)pytest tests/ -q -k 'web_extract or web_tools'— 73 passed, 3 skipped, 0 failures (scoped run; full suite not feasible on this dev machine)