fix: wrap c-S-c keybinding in try/except for prompt_toolkit compat - #19899
Closed
martijn-atakumi wants to merge 1 commit into
Closed
fix: wrap c-S-c keybinding in try/except for prompt_toolkit compat#19899martijn-atakumi wants to merge 1 commit into
martijn-atakumi wants to merge 1 commit into
Conversation
The 'c-S-c' (Ctrl+Shift+C) key name is not a valid Keys value in
prompt_toolkit 3.0.x — ControlShift+letter combinations are unsupported.
This causes an unhandled ValueError on startup in environments running
current prompt_toolkit versions.
Wrap the @kb.add('c-S-c') decorator in a try/except so it silently
skips the binding on versions that don't support it, and automatically
re-enables once prompt_toolkit adds ControlShift+letter support.
alt-glitch
added
type/bug
Contributor
|
Duplicate — the underlying bug was fixed on main before your PR landed.
Closing issue #19903 too. Thanks for jumping on it — appreciate the quick turnaround even if we only needed one of the fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
@kb.add("c-S-c")keybinding (Ctrl+Shift+C) raisesValueErroron startup with prompt_toolkit 3.0.x becauseControlShift+lettercombinations are not validKeysvalues.Fix
Wrap the decorator in a
try/except (ValueError, KeyError)so the binding is silently skipped on versions that don't support it. Once prompt_toolkit addsControlShift+lettersupport, the binding will automatically start working.Notes