Skip to content

fix(feishu): keep topic replies in threads - #19750

Closed
yuqianma wants to merge 1 commit into
NousResearch:mainfrom
yuqianma:fix/feishu-progress-thread-yuqian
Closed

yuqianma wants to merge 1 commit into
NousResearch:mainfrom
yuqianma:fix/feishu-progress-thread-yuqian

Conversation

@yuqianma

@yuqianma yuqianma commented May 4, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • route Feishu topic progress/status/approval/stream/fallback messages through the triggering message reply target
  • preserve thread metadata plus the originating message id so Feishu uses message.reply with reply_in_thread=true instead of creating a new topic
  • keep the fix scoped to Feishu while retaining existing tool progress behavior
  • add regression coverage for topic-scoped progress metadata and metadata-driven Feishu threaded replies

Tests

  • python -m pytest tests/gateway/test_feishu.py tests/gateway/test_run_progress_topics.py -q -o addopts=

@alt-glitch alt-glitch added type/bug Something isn't working platform/feishu Feishu / Lark adapter comp/gateway Gateway runner, session dispatch, delivery P2 Medium — degraded but workaround exists labels May 4, 2026
@alt-glitch

Copy link
Copy Markdown
Contributor

Related to #13860 and #9384 (earlier attempts to fix the same Feishu thread progress leak). This PR touches gateway/run.py rather than the Feishu adapter directly.

@alt-glitch

Copy link
Copy Markdown
Contributor

Related to #13860 and #9384.

@yuqianma
yuqianma force-pushed the fix/feishu-progress-thread-yuqian branch from e9088da to b4ce0e2 Compare May 4, 2026 14:28
Route Feishu topic progress, status, approval, stream, and fallback messages through threaded replies by preserving the originating message id as the reply target. Add regressions for tool progress topic metadata and Feishu metadata-driven reply routing.
@yuqianma yuqianma changed the title fix(feishu): keep progress updates in threads fix(feishu): keep topic replies in threads May 4, 2026
@kshitijk4poor

Copy link
Copy Markdown
Contributor

Merged via PR #20851. Your fix was cherry-picked onto current main (273 commits ahead) with your authorship preserved in git log. Two small cleanups were added on top: removed a dead metadata.get('reply_to') fallback and simplified the _status_thread_metadata construction. Thanks for the thorough fix and tests! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery P2 Medium — degraded but workaround exists platform/feishu Feishu / Lark adapter type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants