fix(gateway): deduplicate Weixin messages by content fingerprint - #19742
Merged
Conversation
19 tasks
alt-glitch
added
type/bug
1 task
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #16190 by @PratikRai0101 onto current main.
Summary
The Weixin (ilinkai) upstream occasionally delivers the same logical message twice within a ~3-second window with distinct
message_idvalues, so the existingmessage_id-based dedup misses the duplicate and the agent handles both copies. Add a secondary content-fingerprint dedup keyed oncontent:<sender_id>:<md5(text)>to catch the real duplicate case, only for text messages.Conflict resolution during salvage
Test file picked up a
TestIsStaleSessionRetclass from a separate landed fix; preserved both that class and the newTestWeixinContentDedupclass.Changes
Validation
scripts/run_tests.sh tests/gateway/test_weixin.py -> 51 passed
Original PR: #16190
Fixes: #16182