fix(compressor): _prune_old_tool_results boundary direction - #19725
Merged
Conversation
13 tasks
alt-glitch
added
type/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #16228 onto current main.
Summary
The function's docstring promised 'the token budget takes priority and the message count acts as a hard minimum floor', but
prune_boundary = max(boundary, len(result) - min_protect)inverted the semantics in index-space (smaller index = more protected). A generous budget silently got truncated back down tomin_protect. Translate the budget walk into a protected count, apply the floor in count-space, convert back to a prune boundary.Validation
scripts/run_tests.sh tests/run_agent/ -k compressor -> passed
Original PR: #16228