fix(gateway): show friendly error when service is not installed - #19707
Merged
Conversation
Instead of an unhelpful CalledProcessError traceback when running `hermes gateway start/stop/restart` without first installing the service, check for the unit file and exit with an actionable install hint. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 tasks
alt-glitch
added
type/bug
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #15922 by @h0tp-ftw onto current main.
Summary
Running
hermes gateway start/stop/restartwithout first installing the service surfaced a rawCalledProcessErrortraceback from systemctl (Unit hermes-gateway.service not found). Add a_require_service_installed()preflight that prints a clear "✗ Gateway service is not installed" + "Run: hermes gateway install" message and exits with code 1.Conflict resolution during salvage
Main has added a
test_run_gateway_refreshes_outdated_unit_on_boottest to the same class. Preserved both the existing test and the PR's newTestRequireServiceInstalledclass.Changes
_require_service_installed(action, system=False)preflight called from systemd_start/stop/restartTestRequireServiceInstalledclass with install-hint + pass-when-installed casesValidation
scripts/run_tests.sh tests/hermes_cli/test_gateway_service.py -k TestRequireServiceInstalled -> 2 passed
Original PR: #15922