fix(slack): fetch thread context when bot is mentioned in a thread - #1965
Closed
ygd58 wants to merge 1 commit into
Closed
fix(slack): fetch thread context when bot is mentioned in a thread#1965ygd58 wants to merge 1 commit into
ygd58 wants to merge 1 commit into
Conversation
ygd58
force-pushed
the
fix/slack-thread-context-on-mention
branch
from
March 18, 2026 17:37
84cb95f to
4b26503
Compare
1 task
Contributor
Author
|
The test failures (ImportError: cannot import name '_rich_text_from_ansi') are pre-existing failures unrelated to this PR. The function was removed from cli.py in a previous upstream commit but the test file wasn't updated. The slack.py changes are isolated and clean. |
ygd58
force-pushed
the
fix/slack-thread-context-on-mention
branch
from
March 19, 2026 16:16
4b26503 to
d886054
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1953
Problem
When @mentioning Hermes in a Slack thread, it had no awareness of the thread's conversation history. It could only see the current message.
Fix
When the bot is mentioned inside a thread (thread_ts != ts), fetch the last 20 messages via conversations_replies API and prepend them to the message as context:
[Thread context:]
User: test
User: @rocky can you read this thread
[New message:]
Notes