fix(cron): skip AI call when prerun script produces no output - #19628
Merged
Conversation
When a cron job has a pre-run script that runs successfully but produces no output (e.g. email checker with no new mail), the scheduler previously injected "[Script ran successfully but produced no output.]" into the prompt and still called the AI model. This wastes tokens on every cycle. Now _build_job_prompt() returns None when script output is empty, and run_job() short-circuits with a SILENT response - zero API calls when there is nothing to report.
alt-glitch
added
type/perf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #15223 onto current main.\n\n## Summary\nWhen a cron pre-run script runs successfully but produces no output (e.g. an email checker with an empty inbox), the scheduler injected 'Script ran successfully but produced no output' and still called the AI model \u2014 288 wasted API calls/day for a 5-minute interval job. Return None from and short-circuit with a SILENT_MARKER in that case.\n\n## Validation\nManual review; diff scope self-contained.\n\nOriginal PR: #15223