fix(weixin): handle cross-event-loop session reuse in send_weixin_direct - #19481
Closed
eipiem1 wants to merge 1 commit into
Closed
fix(weixin): handle cross-event-loop session reuse in send_weixin_direct#19481eipiem1 wants to merge 1 commit into
eipiem1 wants to merge 1 commit into
Conversation
When cron jobs deliver results to Weixin, send_weixin_direct() attempts to
reuse the cached live adapter's aiohttp session (created on the gateway's
event loop). However, standalone cron delivery runs via asyncio.run() on a
different event loop. aiohttp's TimerContext.__enter__() calls
asyncio.current_task(loop=gateway_loop) which returns None on the standalone
loop, raising RuntimeError('Timeout context manager should be used inside a
task').
Fix: wrap the live-adapter reuse path in try/except RuntimeError so it falls
through to creating a fresh aiohttp session on the current event loop.
Fixes cron delivery failures for Weixin platform.
Collaborator
Collaborator
Author
|
Thanks for the heads up @alt-glitch! Closing in favor of the existing PRs (#14481, #12810, #15911). The fix was already known — appreciate the pointer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When cron jobs deliver results to Weixin,
send_weixin_direct()attempts to reuse the cached live adapter's aiohttp session (created on the gateway's event loop). However, standalone cron delivery runs viaasyncio.run()on a different event loop.aiohttp's
TimerContext.__enter__()callsasyncio.current_task(loop=gateway_loop), which returnsNoneon the standalone loop, raising:This causes all cron deliveries to the Weixin (WeChat) platform to fail silently.
Fix
Wrap the live-adapter reuse path in
try/except RuntimeErrorso it falls through to creating a freshaiohttp.ClientSessionon the current event loop. The fresh session path was already implemented — it just wasn't reachable when a cached live adapter was present.Impact