fix(compressor): skip non-string tool content in dedup pass to prevent AttributeError - #19398
Merged
Conversation
3 tasks
alt-glitch
added
type/bug
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #19373 by @sprmn24 onto current main.
Summary
_prune_old_tool_resultsskipslistcontent (multimodal blocks) but then callscontent.encode()directly. If a tool result has non-string content (dict,int,bool), this raisesAttributeErrorand breaks context compression entirely. Add anisinstance(content, str)guard before the length/hash path.Changes
Validation
scripts/run_tests.sh tests/agent/ -k compress → 91 passed
Original PR: #19373