fix(gateway): hide required-arg commands from Telegram menu - #19343
Closed
mrbob-git wants to merge 1 commit into
Closed
fix(gateway): hide required-arg commands from Telegram menu#19343mrbob-git wants to merge 1 commit into
mrbob-git wants to merge 1 commit into
Conversation
Contributor
|
Salvaged via #19400 onto current main — your commit's authorship was preserved. Thanks @mrbob-git! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Telegram BotCommand menu selections send only the bare
/command. Commands such as/background,/queue, and/steerrequire a prompt argument, so listing them in the Telegram native command menu lets users select an incomplete command that executes immediately.This keeps those commands available for manual gateway dispatch, but skips commands whose
args_hintstarts with<...>when building the Telegram BotCommand menu. Plugin slash commands with required arguments get the same treatment.Related Issue
Fixes #19288
Type of Change
Changes Made
hermes_cli/commands.py: skip required-argument commands when generating Telegram BotCommand entries.tests/hermes_cli/test_commands.py: add regression coverage for core commands and plugin commands with required arguments.How to Test
python -m pytest tests/hermes_cli/test_commands.py -q -o addopts=./background,/queue, and/steerare not returned bytelegram_bot_commands().GATEWAY_KNOWN_COMMANDSfor manual dispatch.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
Targeted validation passed locally:
I also attempted the repo wrapper with
bash scripts/run_tests.sh tests/hermes_cli/test_commands.py -q -o addopts=, but this Windows checkout has CRLF line endings and bash exited before running the script (set: pipefail\r: invalid option name).