Skip to content

feat: add Kanban PR review lifecycle - #19314

Closed
tw3akercc wants to merge 2 commits into
NousResearch:mainfrom
tw3akercc:feat/kanban-pr-review-loop-20260503
Closed

feat: add Kanban PR review lifecycle#19314
tw3akercc wants to merge 2 commits into
NousResearch:mainfrom
tw3akercc:feat/kanban-pr-review-loop-20260503

Conversation

@tw3akercc

Copy link
Copy Markdown

Summary

  • Adds PR review lifecycle states for Hermes Kanban coding tasks: in_review, code_review, and merge_ready.
  • Moves PR-bearing task completions into review instead of treating “PR opened” as done.
  • Adds a one-shot PR review poller that classifies pending/failed/green checks and review-thread feedback while tracking seen IDs.
  • Reserves done for post-merge/deployed work; green + approved now becomes merge_ready.

Test Plan

  • python -m pytest tests/hermes_cli/test_kanban_pr_review.py tests/hermes_cli/test_kanban_core_functionality.py tests/hermes_cli/test_kanban_cli.py tests/hermes_cli/test_kanban_db.py tests/plugins/test_kanban_dashboard_plugin.py tests/tools/test_kanban_tools.py -o 'addopts=' -q
  • git diff --check

Notes

  • This came from Kanban task t_29782dca.
  • Branch was pushed from a fork because the local GitHub account does not have direct push permission to NousResearch/hermes-agent.

@alt-glitch alt-glitch added type/feature New feature or request P3 Low — cosmetic, nice to have comp/plugins Plugin system and bundled plugins labels May 3, 2026
@teknium1

Copy link
Copy Markdown
Contributor

Thanks @tw3akercc — closing this one. Multi-state PR-review lifecycle (in_review/code_review/merge_ready statuses with prompts/skills/dashboard changes) is design-level scope (1139 LOC). We just landed review as a status via #28449 (salvage of #23772) which is simpler and uses the dispatcher's existing claim+spawn lifecycle. A multi-state PR-review workflow on top of that needs design discussion: what does each state mean, who transitions, how does it interact with the existing review column. If you want to revisit, an issue first would help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants