fix(skills): curator no longer misclassifies hub skills with non-ASCII names - #19311
Closed
konsisumer wants to merge 1 commit into
Closed
konsisumer wants to merge 1 commit into
konsisumer wants to merge 1 commit into
Conversation
…I names _read_hub_installed_names() now also resolves the SKILL.md display name for each hub entry via install_path, so skills like "Get笔记" (slug "getnote") are added to the off-limits set alongside their slug. list_agent_created_skill_names() additionally checks the skill's directory path against hub install_path values as a belt-and-suspenders guard for cases where the SKILL.md cannot be read. Fixes NousResearch#19293
alt-glitch
added
type/bug
Contributor
Contributor
19 tasks
Contributor
Author
|
Closing — deferring to #19297 by @liuhao1024 which addresses the same. Reopen if that PR stalls. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hub-installed skills whose SKILL.md
namefield differs from their hub slug (e.g.Get笔记for sluggetnote) were being treated as agent-created by the curator, causing them to be merged into umbrella skills and archived.What changed and why
_read_hub_installed_names()now also resolves the SKILL.md display name for each hub entry viainstall_pathand adds it to the off-limits set alongside the slug. This fixesis_agent_created()for display names like"Get笔记"that don't match the hub slug"getnote"._read_hub_installed_dirs()helper that returns normalizedinstall_pathvalues from the lock file.list_agent_created_skill_names()additionally checks each skill's relative directory path against the hub install dirs as a belt-and-suspenders guard for cases where the SKILL.md is unreadable and the display name cannot be resolved...traversal guard when resolvinginstall_pathvalues from lock.json.How to test
name(e.g.Get笔记with sluggetnote).hermes curator run.pytest tests/tools/test_skill_usage.py -q— all 41 pass including 3 new regression tests.What platforms tested on
Fixes #19293